Replaced library_fs.js/random_device()'s Math.random fallback call with throw for safety #7096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulshapiro
added a commit
to mymonero/mymonero-core-js
that referenced
this pull request
Sep 4, 2018
…n-core/emscripten#7096 and replaced Math.random in list rand index in monero_sendingFunds_utils
kripken
approved these changes
Sep 4, 2018
src/library_fs.js
Outdated
| @@ -1301,7 +1301,7 @@ mergeInto(LibraryManager.library, { | |||
| #endif // ENVIRONMENT_MAY_BE_NODE | |||
| } else { | |||
| // default for ES5 platforms | |||
| random_device = function() { return (Math.random()*256)|0; }; | |||
| random_device = function() { throw "emscripten random_device implementation must be run on a modern browser to support safe random number generation."; }; | |||
There was a problem hiding this comment.
Please use abort("..text..") instead of throw - abort will also mark the program as halted, so an emscripten_main_loop etc. will know to stop itself next time it is called.
For the error text, I'd prefer something short, just to not increase code size too much. How about just "random_device", and in a comment (which in an optimized build would be removed) to give the extra detail?
|
Thanks! Updates pushed. |
|
Perfect, thanks @paulshapiro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #542