Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the FluffyChat name and version to the userAgent string #912

Open
inexcode opened this issue Feb 28, 2024 · 3 comments
Open

Add the FluffyChat name and version to the userAgent string #912

inexcode opened this issue Feb 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@inexcode
Copy link
Contributor

Feature Description

Right now, Fluffy's userAgent is Dart/3.3 (dart:io). It should at least contain something like FluffyChat/1.8.0.

This might be also an issue of the Famedly Matrix SDK if it doesn't expose the userAgent setting and doesn't use a more sensible default value.

Rationale

Using generic library useragents is often discouraged in production environments and is not useful for me as an admin. If the client misbehaves, I should know the exact client and its version.

Mockup

No response

Additional Context

The current userAgent is probably taken from here: https://api.dart.dev/stable/3.3.0/dart-io/HttpClient/userAgent.html

Example of the value suggested in the Matrix chat: FluffyChat/1.8.0 Dart/3.3 Android/14

How it shouldn't look like: element-hq/element-meta#2309

@inexcode inexcode added the enhancement New feature or request label Feb 28, 2024
@Mikaela
Copy link
Collaborator

Mikaela commented Mar 11, 2024

Adding keyword user-agent since I had to manually scroll all issues to find this again since GitHub search didn't find either that word or just agent.

Copy link

github-actions bot commented Aug 5, 2024

This issue is stale because it has been open for 120 days with no activity.

@github-actions github-actions bot added the stale The item is going to be closed soon because of inactivity label Aug 5, 2024
@Mikaela
Copy link
Collaborator

Mikaela commented Aug 5, 2024

I haven't been shown any server logs recently, nut I think this is still relevant

@github-actions github-actions bot removed the stale The item is going to be closed soon because of inactivity label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants