Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bad SSL cert case w/ better error thrown to user or acting like Element #88

Closed
krille-chan opened this issue Jul 15, 2023 · 2 comments
Labels
stale The item is going to be closed soon because of inactivity

Comments

@krille-chan
Copy link
Owner

Description

A clear and concise description of what the issue is about.

When connecting to a Matrix server w/ a bad SSL cert wherein the domain names listed don't match the actual domain, FluffyChat throws an error about a "bad password" to the end user. This obfuscates info that a user could then take to the Homeserver admins to be acted on and can cause user frustration over entering the correct password multiple times. It instead should either handle the issue as Element does or otherwise throw an error about conflicting domains in the SSL cert to the user instead of bad password.

For example, someone may have the SSL cert for abc.social have the listed domain be matrix.abc.social instead of abc.social.

Element seems to be the outlier in ignoring(?) this cert conflict and connects users as NeoChat also currently has login issues for this case

To Reproduce

If this issue is describing a bug, include some steps to reproduce the behaviour.

  1. Try to connect to Homeserver instance w/ a SSL cert that lists a different domain. At time of writing monero.social is one such site w/ a cert domain of matrix.monero.social. If you are unsure if the site has a conflictive cert, you can use: https://www.ssllabs.com/ssltest/analyze.html
  2. Verify that you get a 'Bad Password' error thrown

Additional information:

  • Device: Fedora 34 KDE, Android 11
  • OS and OS version: N/A
  • Installed version of FluffyChat: Flathub 2021/05/26 release, Android 0.31.1
  • (Android only) Which store are you using: F-droid
  • (Android only) Are Google Services available: Yes

/issue fluffy

Copy link

github-actions bot commented Mar 7, 2024

This issue is stale because it has been open for 120 days with no activity.

@github-actions github-actions bot added the stale The item is going to be closed soon because of inactivity label Mar 7, 2024
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The item is going to be closed soon because of inactivity
Projects
None yet
Development

No branches or pull requests

1 participant