Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for memory_reservation in Docker Terraform Provider #662

Open
Yanpei-Wang opened this issue Dec 14, 2024 · 0 comments
Open

Support for memory_reservation in Docker Terraform Provider #662

Yanpei-Wang opened this issue Dec 14, 2024 · 0 comments

Comments

@Yanpei-Wang
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When attempting to set a memory soft limit for a Coder workspace, I found that the Docker Terraform provider is missing the memory_reservation configuration. This functionality needs to be added.

New or Affected Resource(s)

The relevant parts of the code related to memory handling are:

resource_docker_container_funcs.go
resource_docker_container_funcs.go
resource_docker_container.go

These sections handle memory configuration, so a similar approach should be used to add memory_reservation. The value should be populated in container.HostConfig.MemoryReservation.

References

Docker API - Resources: MemoryReservation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@Yanpei-Wang and others