.dockerignore white-list pattern causes error

[1Mill]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and docker Provider) Version

Terraform v1.0.2

Affected Resource(s)

• docker_registry_image

Terraform Configuration Files

Folder structure:

• app
  • empty
  • .dockerignore
  • Dockerfile
  • main.tf

empty

# This this an empty file

.dockerignore

*

!empty

Dockerfile

FROM scratch
COPY empty /empty

main.tf

terraform {
  required_version = "~> 1.0"

  required_providers {
    docker = {
      source  = "kreuzwerker/docker"
      version = ">= 2.14.0"
    }
  }
}

provider "docker" {...}

resource "docker_registry_image" "this" {
  name = "my-image-name"

  build {
    context = abspath(path.module)
  }
}

Debug Output

Expected Behaviour

Successfully build and publish image to registry.

Actual Behaviour

Error: Error building docker image: Error response from daemon: Cannot locate specified Dockerfile: Dockerfile

Steps to Reproduce

1. terraform init
2. terraform apply -auto-approve

Important Factoids

• The error only occurs when using the white-list pattern in the .dockerignore file. This implies to me that something is wrong with the * interpretation / pattern in the module.

[github-actions]

This issue is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 7 days.
If you don't want this issue to be closed, please set the label pinned.

[JavaScriptBach]

I think the actual issue is that Dockerfiles must not be excluded before being passed to the API. I ran into a similar issue today (docker build worked fine, but missing Dockerfiles when using this provider) and finally resolved it by changing .dockerignore to not exclude Dockerfiles.

If you take a look at the CLI code, you can see it's excluding Dockerfile and .dockerignore before passing them to the API, along with a bunch of other complicated logic that has no equivalent in the provider. My guess is we need to implement something similar in order for this provider to behave more comparably to docker build.

Specifically what seems to not be implemented in the terraform docker provider is this:

You can even use the .dockerignore file to exclude the Dockerfile and .dockerignore files. These files are still sent to the daemon because it needs them to do its job. But the ADD and COPY instructions do not copy them to the image.

See docs

[Junkern]

This should be fixed with the newest version https://github.com/kreuzwerker/terraform-provider-docker/releases/tag/v2.18.0
Even added the files you posted for reproduction as a test case :)