Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedy derive macro is throwing clippy errors in downstream crates #34

Open
danieleades opened this issue Nov 25, 2022 · 1 comment
Open

Comments

@danieleades
Copy link

danieleades commented Nov 25, 2022

error: this public function might dereference a raw pointer but is not marked `unsafe`
   --> src/structure/guid.rs:476:3
    |
476 |   Readable,
    |   ^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
    = note: this error originates in the derive macro `Readable` (in Nightly builds, run with -Z macro-backtrace for more info)

Presumably this is because the Readable trait derived implementation has methods that dereference raw pointers. These could in principle be anything, so the methods are inherently unsafe and should be marked as such. That's most likely a breaking change (worth making).

@danieleades
Copy link
Author

looks like this may have already been addressed in 1a2ec91 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant