Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irrelevant linting errors on JSON files #6

Open
nlydv opened this issue Jun 18, 2022 · 2 comments
Open

Irrelevant linting errors on JSON files #6

nlydv opened this issue Jun 18, 2022 · 2 comments
Assignees

Comments

@nlydv
Copy link

nlydv commented Jun 18, 2022

This has been something I've noticed occasionally whenever using the extension with an open JSON file:

Screen Shot 2022-06-17 at 9 30 04 PM

At first I though this was an issue from one of the JSON linting extensions I have installed, but it says it's from µEslint on hover.

Of course, my JSON is not actually missing a semicolon. I'm not using any extra eslint plugins that lint JSON files. Surprisingly, I ran eslint on the same file from the command line and it did give the same result.

Perhaps it would be beneficial to add an extension preference which allows the user to set a glob pattern or list of file types that it should lint exclusively. That way if someone wanted to lint JSON files (or any one of the numerous JS-derived files) using eslint, they could, and vice versa.

Even though this extension is meant to be simple, bare bones, and supposed behave as if you ran the eslint command manually, I think just this one user configurable option might be justified here since invoking the CLI naturally already involves passing such information as an argument anyways. May also help with performance for some.

@kopischke kopischke self-assigned this Jun 22, 2022
@kopischke
Copy link
Owner

Hey @nlydv, thanks for opening this. As I am currently undergoing cancer treatment, it might be a little while before I can reasonably address this issue. Please bear with me, and thank you for your understanding.

@nlydv
Copy link
Author

nlydv commented Jun 24, 2022

Terribly sorry to hear that, no worries whatsoever.

Wishing all the best for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants