Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment script has a redundant argument #10

Open
eisraeli opened this issue Nov 1, 2024 · 3 comments
Open

Deployment script has a redundant argument #10

eisraeli opened this issue Nov 1, 2024 · 3 comments

Comments

@eisraeli
Copy link
Contributor

eisraeli commented Nov 1, 2024

Current deployment command:
./deploy-argocd.sh <ArgoCD server> <production/staging>

The script only uses the ArgoCD server URL. It's unique per environment.
I suggest dropping the second argument.

@avi-biton
Copy link
Contributor

@eisraeli PTAL at the last changes we did.
To sum it, we removed the ArgoCD server parameter from the script since it is not needed.
All the commands we run in this script are using kubectl and there is no meaning to the fact we logged in to Argo, we are not using Argo in the script.
The other parameter is kept to let us deploy both staging and production (maybe dev in the future)

@eisraeli
Copy link
Contributor Author

eisraeli commented Nov 6, 2024

@avi-biton Is there a pending PR with the changes ?

@avi-biton
Copy link
Contributor

We had some merged PRs recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants