Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set per revision headers in Cluster Ingress #4755

Closed
vagababov opened this issue Jul 15, 2019 · 3 comments · Fixed by #4823
Closed

Set per revision headers in Cluster Ingress #4755

vagababov opened this issue Jul 15, 2019 · 3 comments · Fixed by #4823
Labels
area/networking kind/bug Categorizes issue or PR as related to a bug.
Milestone
0.8.x

Comments

@vagababov
Copy link
Contributor

/area networking

This is required for TBC to work in the blue-green style deployments.
This requires us to update min supported Istio version to be 1.1.

/cc @tcnghia @mattmoor
@vagababov vagababov added the kind/bug Categorizes issue or PR as related to a bug. label Jul 15, 2019
@mattmoor
Copy link
Member

1.0 is technically EoL, and we need the per-split header injection to correctly implement our semantics with the activator on the request path.

This is on the TOC agenda for Thursday.

@dprotaso
Copy link
Member

dprotaso commented Jul 18, 2019 •
edited
Loading

drop 1.0

burn it

@tcnghia tcnghia mentioned this issue Jul 19, 2019
Merged
@mattmoor
Copy link
Member

💥

🎤 👇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/networking kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
0.8.x
Development

Successfully merging a pull request may close this issue.

Turn on per-split header appending. tcnghia/serving
5 participants
@dprotaso @tcnghia @vagababov @mattmoor @knative-prow-robot