Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a Route prober to confirm effectiveness of VirtualService changes #1582

Closed
tcnghia opened this issue Jul 12, 2018 · 4 comments
Closed
Assignees
Milestone

Comments

@tcnghia
Copy link
Contributor

tcnghia commented Jul 12, 2018

Expected Behavior

When we report that a Route is Ready, it should be accessible through Ingress.

Actual Behavior

However, after we create a VirtualService there is some delay before it routes are working and currently the v1alpha3 API doesn't provide a good way to know when (istio/istio#882).

As a stop-gap we could add a special route in our VirtualService that always return the Route/VirtualSerice version. Then when Routes change we can add a prober Pod to probe all ingress pods to make sure that all ingress Pods are seeing updated version of the Routes and mark them with IngressReady condition.

This way users (and integration tests) can start relying on Route.Status more. When istio/istio#882 is fixed we simply replacing these probers by the newly provided mechanism.

Additional Info

This will also remove some of the Polling/Probing noted in #1178

@google-prow-robot google-prow-robot added area/API API objects and controllers area/networking labels Jul 12, 2018
@tcnghia tcnghia changed the title Needs a Route prober to confirm effectiveness of VirtualService changes Need a Route prober to confirm effectiveness of VirtualService changes Jul 12, 2018
@lichuqiang
Copy link
Contributor

I've seen a lot of folks (including myself) claiming that they need a way to confirm a VirtualService is indeed ready to serve. But I failed to see progress in istio/istio#882.

So maybe it's time to revisit this? I'd like to pick this up if you've no objection.

@lichuqiang
Copy link
Contributor

/assign

@lichuqiang
Copy link
Contributor

I've got some POC code for IngressGateway side probe here in my repo: https://github.com/lichuqiang/serving/tree/prober

Will consider to post an official PR later if I'm sure we can get rid of this issue on activator side.

@mattmoor mattmoor added this to the Needs Triage milestone Nov 28, 2018
@tcnghia tcnghia modified the milestones: Needs Triage, Serving 0.4 Jan 3, 2019
@mattmoor mattmoor removed the area/API API objects and controllers label Jan 7, 2019
@tcnghia tcnghia modified the milestones: Serving 0.4, Needs Triage, Ice Box Jan 29, 2019
@tcnghia
Copy link
Contributor Author

tcnghia commented May 8, 2019

/cc @greghaynes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants