fix getInitialPageProps return

[alikazemkhanloo]

I think this part is forgotten.

[kirill-konshin]

What issue are you trying to solve? initlalProps and initialState are supposed to be unwrapped during rendering. Can you provide a codesandbox for me to see the scenario when current implementation fails?

[alikazemkhanloo]

Hi,
Current implementation doesn't fail. But normally when I return an object in getInitialProps, it would be available as props, not as a prop inside props.

When i return

{
  name:'a'
}

In getInitialProps, I expect to get name directly in props. when I return the same object in wrapper.getInitialPageProps, I get props.initialProps.name. I think this wrapper should behave like the original function.

[kirill-konshin]

This is exactly how it works. You will get your props unwrapped. The internal objects are needed for transport, you should never see them in your own components. If you do - that’s a bug, and it should be fixed. Can you create a sandbox to illustrate it if you see the internals.

[alikazemkhanloo]

sandbox

[kirill-konshin]

[alikazemkhanloo]

fixed

[kirill-konshin]

I see now, thank you. Let me check why they are leaking.

[kirill-konshin]

This has to be fixed slightly differently, I'm closing this PR, I've referenced the PR in the correct fix fc056a9. Thank you for contributing.

[ypresto]

@kirill-konshin

At least in my environment I got props inside props still after your fix.

cd packages/demo && npm start then localhost:3000/pageProps shows:

[ypresto]

It was because just I forget to run npm build on parent dir. Sorry >_<

[ypresto]

@kirill-konshin

There is another but similar issue that HYDRATE dispatched twice with eventually empty state, when wait for saga.
Reproduced in demo-saga modified to use getInitialPageProps().
It is because getInitialPageProps() returns { initialState } so

next-redux-wrapper/packages/wrapper/src/index.tsx

Line 177 in fc056a9

if (initialStateFromGSPorGSSR)

this line executed after first HYDRATE.

sandbox:
https://codesandbox.io/s/next-redux-wrapper-getinitialpageprops-saga-bug-zfkoi

Just we should wait for saga in getInitialPageProps().