Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.90%. Comparing base (2f7b3ad) to head (682ce88).
Report is 75 commits behind head on master.

In my opinion, this is not correct and even confusing. The agent is not related to and does not use tpm2-tools in any way. It would be weird that by changing tpm2-tools configuration the agent is also affected.

The TCTI configuration should be sufficient, and I believe the confusion comes from missing proper documentation and better error messages.

Kinda agree, this just aligns it more with what was supported by the old agent. This options is still weird regardless, as its the only option that cannot be set via the config/env combintation. Ideally it would be KEYLIME_AGENT_TCTI and the default set as an option in the agent.conf. I can change it to that if you want.

Kinda agree, this just aligns it more with what was supported by the old agent. This options is still weird regardless, as its the only option that cannot be set via the config/env combintation. Ideally it would be KEYLIME_AGENT_TCTI and the default set as an option in the agent.conf. I can change it to that if you want.

I think that making it a configuration option makes a lot of sense. Adding the tcti config option, which would result on KEYLIME_AGENT_TCTI env var being supported would be the ideal.

Unfortunately, we would have to still support the plain TCTI env var for compatibility. But it is no different from some other options we have.

Ok I'll close this PR then and send a new one to add this as an option + override if TCTI env is set.