Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinction between 0 and -0 #3

Closed
pvdz opened this issue Jul 1, 2015 · 11 comments
Closed

Distinction between 0 and -0 #3

pvdz opened this issue Jul 1, 2015 · 11 comments

Comments

@pvdz
Copy link

pvdz commented Jul 1, 2015

Do you care about this? It's an observable distinction. This module seems to ignore it.
@arthurvr
Copy link
Collaborator

arthurvr commented Jul 1, 2015

See #1 and #2. We decided not to care about it.

I'm going to leave the issue open as maybe we should have a note in the readme.

@pvdz
Copy link
Author

pvdz commented Jul 1, 2015

Ah yeah, that would have prevented my issue. Sorry about that.

@arthurvr
Copy link
Collaborator

arthurvr commented Jul 1, 2015

No worries. I agree this should've been better documented than the example we have now. It's gonna cause confusion.

@pvdz pvdz mentioned this issue Jul 1, 2015
Closed
@pvdz
Copy link
Author

pvdz commented Jul 1, 2015

Just put two (or three, if you want +0 too) zero test cases in there, with a description of why the result is what it is. It was the first thing I looked at for checking this support :)

@eddiemonge
Copy link

What is the observable distinction? I am confused by this.

@pvdz
Copy link
Author

pvdz commented Jul 2, 2015

1/0 vs 1/-0. "observable" means you can observe the difference, it's not just a spec thing.

@kevva
Copy link
Owner

kevva commented Jul 13, 2015

@qfox, PR welcome.

@pvdz
Copy link
Author

pvdz commented Jul 13, 2015

@kevva PR that changes what exactly?

@kevva
Copy link
Owner

kevva commented Jul 13, 2015

Better documentation :).

@pvdz
Copy link
Author

pvdz commented Jul 13, 2015

I personally don't agree with this decision so I don't think I'm the right person to make these docs.

@abhishekc-sharma abhishekc-sharma mentioned this issue Oct 25, 2015
Closed
@arthurvr
Copy link
Collaborator

arthurvr commented Nov 6, 2015

Closing this as the PR landed.

@arthurvr arthurvr closed this as completed Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eddiemonge @pvdz @kevva @arthurvr