-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the logging while building the docker image #727
base: master
Are you sure you want to change the base?
Conversation
@lfoppiano Looks good. Will definitely help users avoid some surprises when they use the image from DockerHub. |
I am not sure it is a good idea:
If we want to avoid logs in the container, why don't we simply use a volume which will be managed on the host:
Nothing else to do I think. This is also a good choice for persistent data and it easier than bind mount which requires something in the command line. This would allow logging and avoid automatically modifying the config files, which is a bit confusing for the user who sets the settings. |
The abbreviated idea around Docker logging is that the Docker runtime captures the logs using a log driver. In the simplest (and I believe default) case, Docker captures standard out & standard error and stores them, so the console logs will still be available. Additionally, putting the |
This PR removes the log on a file of the application. It's performed at runtime while building so that the log file can be kept for other usages.
It requires just that the two marks in the
config.yml
are not removed or modifiedCC @superdude264