3em dash support in references #1012
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chicago reference style has this awful usage of 3em dash to repeat one or several, or all, authors of the previous reference. Although this practice seems to be removed or restricted by the the latest Chicago style guidelines, latex for instance still work with older guidelines and there are tons of back files with this style.
This PR tries to cover 3em dash in references (some training data for this has been added separately), when each three 3em dash sequence refers to one author. The case with one 3em dash sequence used to refer to all the previous authors is not covered, because it seems ambiguous with the case the first author is repeated.
However the real main problems with this crappy mechanism are with OCR, in particular older OCRized PDF. These dashes are never correctly recognized and the reconstruction of the author list becomes just impossible.
Some example:
With numbers:
And finally three 3em dash to repeat all the authors of the previous reference (not just the first!).