Respect BaseCurrency subclass defaults #316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When instantiating the Currency class we need to resolve a `str` currency symbol to its definition class to preserve any attribute overrides. Resolves kalaspuff#254
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 1960 1962 +2
=========================================
+ Hits 1960 1962 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instantiating a currency via the
Currency(str)method, we're losing the defaults set on the currency subclass.This will resolve a currency symbol to its class definition and preserve the defaults.
For example, prior to this fix the following code will fail:
Resolves #254