-
Notifications
You must be signed in to change notification settings - Fork 52
Add storybook to devDependencies. Add class to proptables. #25
Conversation
d26243d |
@@ -18,6 +18,7 @@ | |||
"publish-storybook": "bash .scripts/publish_storybook.sh" | |||
}, | |||
"devDependencies": { | |||
"@kadira/storybook": "^1.35.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @kadirahq/react-storybook-addon-info
repo also has a storybook (storyception??)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont' see any other reference to storybook in package.json. We had to npm install storybook -S to get the project to run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Maxhodges can you open 2 pull requests? I can merge the devDependency commit right now. But we need to discuss the table class commit a bit. Thanks. |
@mnmtanish OK i removed the proptable class from this commit. But I do hope you can add those classes! |
Published |
@mnmtanish thought it would be better if storybook was already included since it's required to run!