Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Add storybook to devDependencies. Add class to proptables. #25

Merged
merged 3 commits into from
Jun 29, 2016

Conversation

Maxhodges
Copy link
Contributor

@mnmtanish thought it would be better if storybook was already included since it's required to run!

@Maxhodges
Copy link
Contributor Author

Maxhodges commented Jun 28, 2016

d26243d
Our semantic-ui CSS classes are messing up the proptable style. Adding this class allows us to target it so we can fix the padding with a custom style.

@Maxhodges Maxhodges changed the title Add storybook to devDependencies. Add storybook to devDependencies. Add class to proptables. Jun 28, 2016
@@ -18,6 +18,7 @@
"publish-storybook": "bash .scripts/publish_storybook.sh"
},
"devDependencies": {
"@kadira/storybook": "^1.35.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @kadirahq/react-storybook-addon-info repo also has a storybook (storyception??)

Copy link
Contributor Author

@Maxhodges Maxhodges Jun 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont' see any other reference to storybook in package.json. We had to npm install storybook -S to get the project to run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thani-sh
Copy link
Contributor

@Maxhodges can you open 2 pull requests? I can merge the devDependency commit right now. But we need to discuss the table class commit a bit. Thanks.

@Maxhodges
Copy link
Contributor Author

@mnmtanish OK i removed the proptable class from this commit. But I do hope you can add those classes!

@thani-sh thani-sh merged commit 7b308bf into storybook-eol:master Jun 29, 2016
@thani-sh
Copy link
Contributor

Published v3.0.9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants