Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytics): Analytics Request Validator and config driven forex feature #6731

Open
maverox opened this issue Dec 3, 2024 · 0 comments · May be fixed by #6733
Open

feat(analytics): Analytics Request Validator and config driven forex feature #6731

maverox opened this issue Dec 3, 2024 · 0 comments · May be fixed by #6733
Assignees
@maverox
Labels
A-Analytics C-doc Category: Documentation updates C-feature Category: Feature request or enhancement C-refactor Category: Refactor M-configuration-changes Metadata: This PR involves configuration changes

Comments

@maverox
Copy link
Contributor

maverox commented Dec 3, 2024

Current behaviour

  • Forex api calls are occuring on every analytics api call
  • There is no analytics request validator.

Proposed Changes

  • Enable/Disable forex functionality based on a config flag.
  • request_validator() to validate requests on various grounds and throw contextual and comprehensive 4xx errors.
  • request_validator() should also be able to discern whether metrics passed in a request, require forex_api call.
@maverox maverox added A-Analytics C-doc Category: Documentation updates C-feature Category: Feature request or enhancement C-refactor Category: Refactor M-configuration-changes Metadata: This PR involves configuration changes labels Dec 3, 2024
@maverox maverox self-assigned this Dec 3, 2024
@maverox maverox changed the title feat(analytics): Analytics Request Validator and Config driven forex feature feat(analytics): Analytics Request Validator and config driven forex feature Dec 3, 2024
@maverox maverox linked a pull request Dec 3, 2024 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maverox maverox

Labels
A-Analytics C-doc Category: Documentation updates C-feature Category: Feature request or enhancement C-refactor Category: Refactor M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(analytics): Analytics Request Validator and config driven forex feature juspay/hyperswitch
1 participant
@maverox