Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: primary color usage in components #910

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: primary color usage in components #910

wants to merge 5 commits into from

Conversation

vsrivatsa-edinburgh
Copy link
Member

@vsrivatsa-edinburgh vsrivatsa-edinburgh commented Jul 3, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Dynamic primary color in components - based on config

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@vsrivatsa-edinburgh vsrivatsa-edinburgh requested a review from a team as a code owner July 3, 2024 13:08
@vsrivatsa-edinburgh vsrivatsa-edinburgh force-pushed the fix/primary_color_analytics branch from 310efe5 to e2f514b Compare July 3, 2024 13:09
@vsrivatsa-edinburgh vsrivatsa-edinburgh self-assigned this Jul 3, 2024
@vsrivatsa-edinburgh vsrivatsa-edinburgh added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed bug bug analytics labels Jul 3, 2024
JeevaRamu0104
JeevaRamu0104 previously approved these changes Jul 3, 2024
View reviewed changes
@vsrivatsa-edinburgh vsrivatsa-edinburgh changed the title fix: primary color in user journey analytics fix: primary color usage in components Jul 3, 2024
@JeevaRamu0104 JeevaRamu0104 self-requested a review July 9, 2024 07:15
@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 9, 2024
@vsrivatsa-edinburgh vsrivatsa-edinburgh added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 10, 2024
@vsrivatsa-edinburgh vsrivatsa-edinburgh marked this pull request as draft July 10, 2024 15:50
@vsrivatsa-edinburgh vsrivatsa-edinburgh added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 Awaiting requested review from JeevaRamu0104

At least 2 approving reviews are required to merge this pull request.

Assignees

@vsrivatsa-edinburgh vsrivatsa-edinburgh

Labels
analytics bug bug S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsrivatsa-edinburgh @JeevaRamu0104