Add playwright based UI integration tests for existing UI #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
changed the title
yuvipanda
force-pushed
the
binderhub-local
branch
11 times, most recently
from
8a5e565 to
9a5f4f3
Compare
Allows using this in integration tests
- Add a new 'integration-tests' directory that does white box UI testing - Install dockerspawner in dev-requirements, as the playwright integration tests now need it - Move loading and about page tests to use playwright - Add some tests for the home page - Use a single instance of local-binder-local-hub for doing thes integration tests - Upload playwright traces (https://playwright.dev/python/docs/trace-viewer) on failure so we can debug things better Co-authored-by: Oliver Roick <[email protected]>
yuvipanda
force-pushed
the
binderhub-local
branch
from
9a5f4f3 to
c41c7c0
Compare
minrk
reviewed
Dec 9, 2024
|
|
||
|
|
||
| def pytest_configure(config): | ||
| # Required for playwright to be run from within pytest |
There was a problem hiding this comment.
The alternative to this is to use async tests with the playwright async API. That's what we use in the jupyterhub tests.
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Dec 9, 2024
jupyterhub/binderhub#1891 Merge pull request #1891 from yuvipanda/binderhub-local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily written to make UI testing easier in #1856, and
steals code from there
UI testing
integration tests now need it
integration tests
on failure as a github artifact so we can debug things better
test_main.py, so we can get rid of it as part of Rewrite the frontend #1856