Unset GIT_CONFIG during git config
#858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
-f .git/config from git configGIT_CONFIG during git config
rwe
reviewed
Aug 7, 2019
| @@ -1625,7 +1625,7 @@ class Plugin(object): | |||
| self.write(Action.DONE, self.name, result[-1:]) | |||
|
|
|||
| def repo_uri(self): | |||
| cmd = 'git rev-parse --abbrev-ref HEAD 2>&1 && git config -f .git/config remote.origin.url' | |||
| cmd = 'git rev-parse --abbrev-ref HEAD 2>&1 && unset GIT_CONFIG && git config remote.origin.url' | |||
There was a problem hiding this comment.
Should the unset be done before the first git rev-parse, I wonder? Could an errant GIT_CONFIG somehow change how --abbrev-ref determines the branch name?
There was a problem hiding this comment.
Re my comment, if that's the case, note that that would be an existing bug rather than a problem introduced by this PR. I think this PR could be merged as is.
11 tasks
janlazo
reviewed
Feb 18, 2020
| @@ -2054,7 +2054,7 @@ endfunction | |||
| function! s:git_validate(spec, check_branch) | |||
| let err = '' | |||
| if isdirectory(a:spec.dir) | |||
| let result = s:lines(s:system('git rev-parse --abbrev-ref HEAD 2>&1 && git config -f .git/config remote.origin.url', a:spec.dir)) | |||
There was a problem hiding this comment.
Is this meant to work on all OS?
|
Yygtt |
|
Conflicting files plug.vim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470, #834
Related #455, #471
GIT_CONFIGonly affectsgit configas documented here. Why don't we just unset it, so that:PlugUpdateworks properly whether plugins are installed byvim-plugorgit submodule.