Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being smarter about common include patterns #802

Closed
kcajf opened this issue Jul 17, 2020 · 1 comment
Closed

Being smarter about common include patterns #802

kcajf opened this issue Jul 17, 2020 · 1 comment
Labels
Milestone

Comments

@kcajf
Copy link

kcajf commented Jul 17, 2020

I've got a module that uses include to pull in some code. If I call "jump to definition" on the include statement, it gets me to the included file - great.

Once I'm in the included file, "jump to definition" doesn't work for symbols that exist in the module that the file is included into. Doing this correctly in general is obviously impossible since we can't know everwhere the file will be included. However, most modules / packages have a very simple tree structure, and most files are included only once either by a file in the same folder or one folder up. Trying to bubble up this tree a few levels, while resolving all symbols in sibling includes could be handy. Would this be difficult?

@davidanthoff davidanthoff added this to the Triage milestone Jul 18, 2020
@ZacLN
Copy link
Contributor

ZacLN commented Feb 8, 2021

I believe this is fixed, do reopen if it persists

@ZacLN ZacLN closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants