Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send "changes": null in WorkspaceEdit on workspace/applyEdit request #763

Closed
jwortmann opened this issue Jun 18, 2020 · 0 comments · Fixed by #765 or #775
Closed

Don't send "changes": null in WorkspaceEdit on workspace/applyEdit request #763

jwortmann opened this issue Jun 18, 2020 · 0 comments · Fixed by #765 or #775
Labels
bug
Milestone
Triage

Comments

@jwortmann
Copy link
Contributor

The server sends "changes": null within WorkspaceEdit in the workspace/applyEdit request (after receiving a workspace/executeCommand). But according to the specs for WorkspaceEdit, changes must not be null. It can just be omitted instead.

#665 doesn't seem to have resolved that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Triage
Development

Successfully merging a pull request may close this issue.

nothing -> missing in WorkspaceEdit julia-vscode/LanguageServer.jl
Fix WorkspaceEdit (again)
2 participants
@davidanthoff @jwortmann