Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump puppeteer dependency version #760

Open
Nezteb opened this issue Mar 21, 2023 · 0 comments
Open

Bump puppeteer dependency version #760

Nezteb opened this issue Mar 21, 2023 · 0 comments

Comments

@Nezteb
Copy link
Contributor

Nezteb commented Mar 21, 2023

Currently puppeteer is pinned to version 16.1.0, which was released on Aug 6, 2022.

There have been a few major versions released since then with the following breaking changes:

17.0.0: https://github.com/puppeteer/puppeteer/releases/tag/v17.0.0

⚠ BREAKING CHANGES

18.0.0: https://github.com/puppeteer/puppeteer/releases/tag/v18.0.0

⚠ BREAKING CHANGES

19.0.0: https://github.com/puppeteer/puppeteer/releases/tag/v19.0.0

⚠ BREAKING CHANGES

The latest version is 19.7.5, released on Mar 14, 2023. Granted, since then there haven't been any direct/explicit changes to the PDF functionality.

Since resume-cli only uses puppeteer for PDF generation, I'd guess/hope that it'd be a relatively painless upgrade straight to 19.7.5. At the very least, the ~/.cache/puppeteer change would make life a bit easier for people when installing. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant