-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --skipTag flag #687
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #687 +/- ##
=======================================
Coverage 96.78% 96.78%
=======================================
Files 28 28
Lines 591 591
Branches 100 100
=======================================
Hits 572 572
Misses 9 9
Partials 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thank you for this PR. I think we would need similar capability.
How would you use this calculated version for other steps? And how would you ensure the same version is then used for creating the tag & a "release" on GitHub? |
I am already doing it with another home-made nx plugin. The version is stored as an environment variable, and other programs that publish packages/images/charts use that version in the registries they publish to.
Unfortunately, as of now, nx doesn't support passing options as env vars to executors, so some of them (such as |
e2d4357
to
369d933
Compare
It would be useful to use the semver plugin as a version calculator, and then use the calculated
${version}
or${tag}
at a later stage. For instance, run it at the beginning of a pipeline to get the version, and then use that version to build packages, images, charts, etc.I have added a
skipTag
flag that allows running the plugin and not tagging the latest commit. In combination withskipCommit
andskipProjectChangelog
, one can run the plugin without modifying the repository.An alternative would be to use
dryRun
, but this doesn't allow calling post targets.