Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bevy_ggrs example for Bevy 0.10 #130

Closed
Tracked by #143
johanhelsing opened this issue Mar 6, 2023 · 4 comments
Closed
Tracked by #143

Update bevy_ggrs example for Bevy 0.10 #130

johanhelsing opened this issue Mar 6, 2023 · 4 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone

Comments

@johanhelsing
Copy link
Owner

johanhelsing commented Mar 6, 2023

No description provided.

@johanhelsing johanhelsing added documentation Improvements or additions to documentation good first issue Good for newcomers blocked Progress cannot be made currently labels Mar 6, 2023
@johanhelsing johanhelsing added this to the 0.6 milestone Mar 6, 2023
@johanhelsing johanhelsing changed the title Update bevy_ggrs_demo for Bevy 0.10 Update bevy_ggrs example for Bevy 0.10 Mar 6, 2023
@johanhelsing johanhelsing added blocked Progress cannot be made currently and removed blocked Progress cannot be made currently labels Mar 12, 2023
@simbleau simbleau mentioned this issue Mar 12, 2023
4 tasks
@johanhelsing
Copy link
Owner Author

It would be really cool if we had a 0.6 release in time for the bevy 0.10 jam in less than two weeks, and this is currently blocking it.

I think to make it in time, we could update the bevy example to use my reflect-based branch of bevy_ggrs: gschup/bevy_ggrs#51

I'm updating the tutorial series to Bevy 0.10 and that branch now (most of the work is updating it to use 0.10 features anyway), then I'll take the example and then we could hopefully do a release.

This library only depends on ggrs, not bevy_ggrs, so the new, non-reflect version of bevy_ggrs, when done, should be compatible with matchbox 0.6 as well (unless there is a breaking relase of ggrs as well, then we'd have to update).

@johanhelsing johanhelsing removed the blocked Progress cannot be made currently label Mar 22, 2023
@johanhelsing
Copy link
Owner Author

Oh, actually, bevy_ggrs has a git dependency on ggrs, not sure if it is really needed, though... will try patching the dependency. Maybe I'll create a new branch that depends on ggrs 0.9.3 instead.

@johanhelsing
Copy link
Owner Author

Okay, another back and forth. I think I'll hold off on this one, and keep the repo free of git dependencies. But I'll also remove it from the 0.6 milestone, as matchbox itself as is, is fully compatible with my (bevy-0.10 compatible) branch of bevy_ggrs. That means we can tag a release of matchbox, and tell people to use a specific branch of bevy_ggrs, and they should be able to use it with bevy-0.10.

Then we'll just update bevy_ggrs example when the official release is out.

@johanhelsing johanhelsing removed this from the 0.6 milestone Mar 23, 2023
@johanhelsing johanhelsing added the blocked Progress cannot be made currently label Mar 23, 2023
@johanhelsing johanhelsing removed the blocked Progress cannot be made currently label Mar 30, 2023
@johanhelsing johanhelsing added this to the 0.6 milestone Mar 30, 2023
@johanhelsing
Copy link
Owner Author

Done in #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant