PickingHitArea - can renderer param be optional?

[goldenratio]

Hi,

Was just wondering, since pixi3d has reference to pixi's Renderer, can we have default value https://github.com/jnsmalm/pixi3d/blob/develop/src/picking/picking-hitarea.ts#L24 for renderer param? might be a bad idea, I guess. Since it's a breaking API. Would like to hear your thoughts?

constructor(public object: Mesh3D | Model, renderer: Renderer = Camera.main.renderer, public camera?: Camera) {
    this._picking = renderer.plugins.picking
  }

[jnsmalm]

Yes, this would have been better but I'm not too keen on changing it at this point because as you already said it breaks the API.

[jnsmalm]

You need this for a specific reason or only convienience?

[goldenratio]

just for convienience

[goldenratio]

sorry to bug you in this again :D
maybe a static function inside PickingHitArea ? I can make a PR

static fromObject(object: Mesh3D | Model): PickingHitArea {
    return new PickingHitArea(Camera.main.renderer, object)
  }

[jnsmalm]

Please create a PR.