Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instructions for using clip server hosted by jina #848

Merged
merged 5 commits into from
Oct 31, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Oct 28, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #848 (db31471) into main (baf94b5) will decrease coverage by 2.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   81.58%   79.49%   -2.10%     
==========================================
  Files          21       21              
  Lines        1575     1575              
==========================================
- Hits         1285     1252      -33     
- Misses        290      323      +33     
Flag Coverage Δ
cas 79.49% <ø> (-2.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/model/trt_utils.py 56.04% <0.00%> (-27.48%) ⬇️
server/clip_server/model/clip_trt.py 69.38% <0.00%> (-16.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added size/m and removed size/s labels Oct 28, 2022
@github-actions
Copy link

📝 Docs are deployed on https://ft-host-by-jina--jina-docs.netlify.app 🎉

@ZiniuYu ZiniuYu requested a review from scott-martens October 28, 2022 06:54
@@ -0,0 +1,95 @@
# Hosted by Jina AI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference betwee hostted by Jina AI and hosted by jCloud? I think this title is misleading. Maybe we can just use # Cloud Hosting?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this page would explain the SaaS product.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One is hosted by Jina, right now the user can only access it but not control it.
The other is hosted on Jcloud, the user has full control of it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this title does not tell the difference

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit 8776784 into main Oct 31, 2022
@numb3r3 numb3r3 deleted the host-by-jina branch October 31, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants