-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update finetuner docs #843
Conversation
Codecov Report
@@ Coverage Diff @@
## main #843 +/- ##
==========================================
- Coverage 81.58% 79.49% -2.10%
==========================================
Files 21 21
Lines 1575 1575
==========================================
- Hits 1285 1252 -33
- Misses 290 323 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -92,6 +94,7 @@ run = finetuner.fit( | |||
learning_rate=1e-5, | |||
loss='CLIPLoss', | |||
cpu=False, | |||
to_onnx=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As finetuner supports open_clip, can we finetune model='ViT-B-32::openai'
in this tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this model name does not match that in finetuner
docs/user-guides/finetuner.md
Outdated
Note that `finetuner`==0.6.2 doesn't support these new clip models trained on Laion2B: | ||
- ViT-B-32::laion2b-s34b-b79k | ||
- ViT-L-14::laion2b-s32b-b82k | ||
- ViT-H-14::laion2b-s32b-b79k | ||
- ViT-g-14::laion2b-s12b-b42k | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we provide the full model list supported in finetuner. This is not a release notes where the updated information is fine. As the official documentation, we should provide complete information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Model names in finetuner are not the same as in cas, which is confusing. Should we creat a mapping for the model names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some minor comments
📝 Docs are deployed on https://ft-docs-finetuner-update--jina-docs.netlify.app 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
since finetuner updates their model repo, we need to update our docs. Also we need to specify
to_onnx=True
infinetuner.fit()