Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to do error handling? #5

Open
munjalpatel opened this issue Jul 24, 2020 · 6 comments
Open

How to do error handling? #5

munjalpatel opened this issue Jul 24, 2020 · 6 comments

Comments

@munjalpatel
Copy link

First of all, this is simply great! Awesome work!!

I am trying to figure out how to properly return errors on exceptions.
Any suggestions?

@jgaskins
Copy link
Owner

Good point. I don't think there's anything in here yet for it for returning any response code other than 0 (OK). I think this is the reason the Ruby implementation requires you to accept the call object in your method, so you can change the status.

I think it'd be a great idea to at least rescue exceptions and return an internal error if this shard doesn't already do that — it's been a while since I looked at that part of the code. 🙂

@munjalpatel
Copy link
Author

Yeah, I think two things are missing:

  1. Error / Exception Management
  2. Authentication / Metadata support

@bendangelo
Copy link
Contributor

Those are two pretty big issues. Are there any plans on implementing them?

@jgaskins
Copy link
Owner

I'm open to suggestions

@bendangelo
Copy link
Contributor

I've opened a PR to add status codes. For auth I'm not sure where to start. #13

@bendangelo
Copy link
Contributor

Also I've noticed, the standard "list" command to see available services is not available. This would be a nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants