Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx deployment should not re-use the same serviecaccount as the artifactory statefulset #1688

Open
bramaq opened this issue Oct 19, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@bramaq
Copy link
Contributor

bramaq commented Oct 19, 2022

Is this a request for help?:


Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Version of Helm and Kubernetes: any

Which chart: artifactory 107.46.3

Which product license (Enterprise/Pro/oss): Enterprise

What happened:
When deploying artifactory via the stable/artifactory helm chart with Nginx enabled, the nginx pods are created using the same service account used by the artifactory pods. This is incorrect as both nginx and artifactory pods have the same "identity" from the k8s point of view.

What you expected to happen:
Artifactory pods and nginx pods should have their own (unique service accounts).

How to reproduce it (as minimally and precisely as possible):

helm install artifactory jfrog/artifactory --set nginx.enabled=true

kubectl get deploy artifactory-artifactory-nginx -o jsonpath='{.spec.template.spec.serviceAccount}' 
artifactory

kubectl get sts artifactory -o jsonpath='{.spec.template.spec.serviceAccount}' 
artifactory

Anything else we need to know:

@shahiinn
Copy link
Collaborator

Thank you for pointing that out. we will take up this request internally.
Further, feel free to raise a PR if you would like to contribute.

@chukka chukka added the bug Something isn't working label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants