feat: improve how jest function calls are resolved to account for import aliases #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
support-resolving-source-method-final
branch
from
ba4b8df to
e6c3360
Compare
G-Rath
changed the title
This was referenced May 28, 2022
G-Rath
force-pushed
the
support-resolving-source-method-final
branch
from
a2fd28e to
92ef9e3
Compare
SimenB
approved these changes
May 28, 2022
| @@ -6,6 +6,7 @@ import { | |||
| TSESTree, | |||
| } from '@typescript-eslint/utils'; | |||
| import { version } from '../../package.json'; | |||
| import { isTypeOfJestFnCall } from './utils/parseJestFnCall'; | |||
There was a problem hiding this comment.
Rename this file to utils/index.ts?
There was a problem hiding this comment.
I was planning on moving everything else in a follow-up PR, as I'll split things across a few more files but wanted to wait until I'd refactored expect parsing since that represents about 1/3rd of the file.
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2022
# [26.4.0](v26.3.0...v26.4.0) (2022-05-28) ### Features * improve how jest function calls are resolved to account for import aliases ([#1122](#1122)) ([781f00e](781f00e))
|
🎉 This PR is included in version 26.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1106 and #1119, and has highlighted a few other improvements (like that
prefer-todoignoresxprefixed methods even though it applies to.skip'd methods, and the ability to supportcontextas an alias ofdescribe).This overhauls how we parse jest methods to leverage the redesign of how to check if something is a jest method that was landed via #1094 so that rules can handle aliased functions.
Because of how this turned out I've ended up doing away with most of the
utilstests as they're now covered by tests in rules - I have only brought them back to cover cases that are not specific to one particular rule.I've kept this to being just focused on implementing #1106 even though I could also do a few more things like add support for
failing(#1118), support parsingexpect, remove support for invalidconcurrentcall chains, etc. I'll be doing follow up PRs straight away for these so that they have their own changelog.Support for parsing
expectcalls in particular will be my next focus as I've got that mostly done already but realised a little bit of extra thinking needs to be done becauseexpectusage is generally inverse to other methods since it goesexpect(..).property.call(...)- I would like to merge the existing parser/api into this new one, but need to decide on a pattern to represent the difference betweenexpectcalls whereexpectitself is called (which is what the current parser handles) andexpectcalls where it's not (which is what the new parser is really looking for, in all cases except forexpect).I also realised while doing this that
spyOnand co are still accessed viajesteven when using@jest/globals- you just importjest(e.g. it'simport { jest } from '@jest/globals';, notimport { spyOn } from '@jest/globals';)Also also while not super important, this makes
lib~4kb smaller which I think is a good sign that it's on the right track :D