Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create prefer-equality-matcher rule #1016

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Dec 31, 2021

This introduces a rule similar to #1015 that checks for use of the strict equality operators and suggests using built-in matchers instead.

I'm expecting to do some code cleanup later since we've getting a few rules that share common functions, so for now it's straightforward but a bit WET.

This is expected to compliment rules like prefer-strict-equal & prefer-to-be which will handle sorting out the more specific matcher to use.

@G-Rath G-Rath requested a review from SimenB December 31, 2021 21:47
@G-Rath G-Rath force-pushed the create-prefer-equality-matcher branch from 9b771cb to 8361bb4 Compare January 14, 2022 18:56
@G-Rath G-Rath force-pushed the create-prefer-equality-matcher branch from 8361bb4 to 2919ce7 Compare January 15, 2022 20:34
@G-Rath G-Rath merged commit 341353b into main Jan 15, 2022
@G-Rath G-Rath deleted the create-prefer-equality-matcher branch January 15, 2022 20:37
github-actions bot pushed a commit that referenced this pull request Jan 15, 2022
# [25.7.0](v25.6.0...v25.7.0) (2022-01-15)

### Features

* create `prefer-equality-matcher` rule ([#1016](#1016)) ([341353b](341353b))
* **valid-expect:** support `asyncMatchers` option and default to `jest-extended` matchers ([#1018](#1018)) ([c82205a](c82205a))
@github-actions
Copy link

🎉 This PR is included in version 25.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant