fix: Don't emit/merge empty substitutions file

jeromelaban · Apr 26, 2024 · f97079d · f97079d
1 parent ea348a1
commit f97079d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/SourceGenerators/Uno.UI.Tasks/Content/Uno.UI.Tasks.targets b/src/SourceGenerators/Uno.UI.Tasks/Content/Uno.UI.Tasks.targets
@@ -204,13 +204,17 @@
 			</_UnoUpriResource>
 		</ItemGroup>
 
+		<PropertyGroup>
+			<_UnoUpriSubstitutionsFile>$(IntermediateOutputPath)\Substitutions\UpriResources.Substitutions.xml</_UnoUpriSubstitutionsFile>
+		</PropertyGroup>
+
 		<UpriSubstitutionsGeneratorTask_v0
 			AssemblyName="$(AssemblyName)"
 			Resources="@(_UnoUpriResource)"
-			OutputFile="$(IntermediateOutputPath)\Substitutions\UpriResources.Substitutions.xml" />
+			OutputFile="$(_UnoUpriSubstitutionsFile)" />
 
 		<ItemGroup>
-			<FileWrites Include="$(IntermediateOutputPath)\Substitutions\UpriResources.Substitutions.xml" />
+			<FileWrites Include="$(_UnoUpriSubstitutionsFile)" Condition="Exists('$(_UnoUpriSubstitutionsFile)')" />
 		</ItemGroup>
 
 	</Target>

diff --git a/src/SourceGenerators/Uno.UI.Tasks/ResourcesGenerator/UpriSubstitutionsGeneratorTask.cs b/src/SourceGenerators/Uno.UI.Tasks/ResourcesGenerator/UpriSubstitutionsGeneratorTask.cs
@@ -29,7 +29,7 @@ public override bool Execute()
 		{
 			// Debugger.Launch();
 
-			if (!string.IsNullOrEmpty(AssemblyName) && Resources != null && !string.IsNullOrEmpty(OutputFile))
+			if (!string.IsNullOrEmpty(AssemblyName) && Resources?.Length > 0 && !string.IsNullOrEmpty(OutputFile))
 			{
 				var xml = new XmlDocument();