fix(textbox): pasting should not clear undo/redo history

jeromelaban · May 20, 2024 · e7dccd2 · e7dccd2
1 parent 057b269
commit e7dccd2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.cs b/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.cs
@@ -1247,7 +1247,7 @@ public void PasteFromClipboard()
 #if __SKIA__
 				try
 				{
-
+					_clearHistoryOnTextChanged = false;
 					_suppressCurrentlyTyping = true;
 #else
 				{
@@ -1258,6 +1258,7 @@ public void PasteFromClipboard()
 				finally
 				{
 					_suppressCurrentlyTyping = false;
+					_clearHistoryOnTextChanged = true;
 				}
 #endif
 

diff --git a/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.skia.cs b/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.skia.cs
@@ -57,7 +57,7 @@ public partial class TextBox
 	private string _textWhenTypingStarted;
 
 	private int _historyIndex;
-	private List<HistoryRecord> _history = new(); // the selection of an action is what was selected right before it happened. Might turn out to be unnecessary.
+	private readonly List<HistoryRecord> _history = new(); // the selection of an action is what was selected right before it happened. Might turn out to be unnecessary.
 
 	private (int start, int length, bool tripleTap)? _multiTapChunk;
 	private (int hashCode, List<(int start, int length)> chunks) _cachedChunks = (-1, new());