Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS endpoint configuration #11

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chriskilding
Copy link

@chriskilding chriskilding commented Feb 26, 2020

Allows AWS endpoint configuration (service endpoint, signing region) to be specified globally.

To do

  • Make EndpointConfiguration an f:optionalProperty (tick the box in the Jenkins UI if you want to override), and add the necessary tests.
  • EndpointConfiguration tests
  • Validate the config in doTestEndpointConfiguration()
  • Support 'Auto' for signingRegion in doTestEndpointConfiguration()
  • Use a service-independent API call to test endpoint connectivity (i.e. not ListSecrets)
  • Test locally with a real dependent plugin (probably S3 plugin)

@chriskilding
Copy link
Author

aws/aws-sdk-java#2251 says that the AWS API does not support generic authentication tests. We can only test aspects of that (does the URL look well-formed, do the config values look sane etc.)

@chriskilding
Copy link
Author

Yes, that was the idea. If client settings can be drawn from this plugin, then we wouldn't need per-plugin configuration for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants