Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullability in copyWith[Series]TimerId functions #3803

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix nullability in copyWith[Series]TimerId functions #3803

merged 1 commit into from
Jul 25, 2024

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Remove the ProgramGridCellHelperKt extension functions on BaseItemDto and re-use those from LiveProgramDetailPopupHelperKt that already had nullability set.

Issues

Fixes #3792

@nielsvanvelzen nielsvanvelzen added bug Something isn't working live-tv Issue related to the live TV feature crash Bug causing app crashes labels Jul 24, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jul 24, 2024
crobibero
crobibero approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@crobibero crobibero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the crash

@nielsvanvelzen nielsvanvelzen merged commit fa4ccd3 into jellyfin:master Jul 25, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the livetv-record-crash branch July 25, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working crash Bug causing app crashes live-tv Issue related to the live TV feature
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

0.17.0-beta4 - Crash when attempting to record LiveTV
3 participants
@nielsvanvelzen @thornbill @crobibero