Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone issues in Live TV guide #3761

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Jul 16, 2024

Changes

  • Migrate all code using Calendar to use LocalDateTime to fix all kinds of timezone related issues in the Live TV guide

Issues

Fixes #3732
Fixes #3748

@nielsvanvelzen nielsvanvelzen added bug Something isn't working live-tv Issue related to the live TV feature labels Jul 16, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jul 16, 2024
start.set(Calendar.MINUTE, start.get(Calendar.MINUTE) >= 30 ? 30 : 0);
start.set(Calendar.SECOND, 1);
LocalDateTime startDateTime = LocalDateTime.ofInstant(start.toInstant(), start.getTimeZone().toZoneId());
public static void getProgramsAsync(Fragment fragment, int startNdx, int endNdx, final LocalDateTime startTime, LocalDateTime endTime, final EmptyLifecycleAwareResponse outerResponse) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
start.set(Calendar.MINUTE, start.get(Calendar.MINUTE) >= 30 ? 30 : 0);
start.set(Calendar.SECOND, 1);
LocalDateTime startDateTime = LocalDateTime.ofInstant(start.toInstant(), start.getTimeZone().toZoneId());
public static void getProgramsAsync(Fragment fragment, int startNdx, int endNdx, final LocalDateTime startTime, LocalDateTime endTime, final EmptyLifecycleAwareResponse outerResponse) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
start.set(Calendar.MINUTE, start.get(Calendar.MINUTE) >= 30 ? 30 : 0);
start.set(Calendar.SECOND, 1);
LocalDateTime startDateTime = LocalDateTime.ofInstant(start.toInstant(), start.getTimeZone().toZoneId());
public static void getProgramsAsync(Fragment fragment, int startNdx, int endNdx, final LocalDateTime startTime, LocalDateTime endTime, final EmptyLifecycleAwareResponse outerResponse) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
start.set(Calendar.MINUTE, start.get(Calendar.MINUTE) >= 30 ? 30 : 0);
start.set(Calendar.SECOND, 1);
LocalDateTime startDateTime = LocalDateTime.ofInstant(start.toInstant(), start.getTimeZone().toZoneId());
public static void getProgramsAsync(Fragment fragment, int startNdx, int endNdx, final LocalDateTime startTime, LocalDateTime endTime, final EmptyLifecycleAwareResponse outerResponse) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@nielsvanvelzen nielsvanvelzen merged commit 5891264 into jellyfin:master Jul 16, 2024
6 checks passed
@nielsvanvelzen nielsvanvelzen deleted the livetv-correct-time branch July 16, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working live-tv Issue related to the live TV feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.17.0 beta 3] Crashes when accessing TV guide Live TV playback
2 participants