Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ExoPlayer HTTP timeouts #3759

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

nielsvanvelzen
Copy link
Member

By default media3.exoplayer uses a 8 second timeout for connecting & reading. In some cases the Jellyfin server will take longer to respond. @Bond-009 pointed out this is particularly the case with BDMV. This PR sets our own timeouts based on the values in the Kotlin SDK.

The new playback code reads the values from the SDK, the old code got it hardcoded because it's end of life anyway.

Changes

  • Add new ExoPlayerOptions
    • Re-use HTTP timeouts from ApiClient for ExoPlayer
  • Set HTTP timeouts in VideoManager ExoPlayer

Issues

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Jul 16, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jul 16, 2024
@nielsvanvelzen nielsvanvelzen merged commit 181bb62 into jellyfin:master Jul 16, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the playback-timeouts branch July 16, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants