Improve BlurHash decoding performance #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Thanks for the pull request. I'm not against using our own implementation as it won't need much maintenance (it's just a single file).
It should use our package name (probably somewhere in utils) and follow our code style (use tabs).
Additionally, the Detekt warnings can be suppressed for this file as the magic numbers are to be expected.
cbeyls
force-pushed
the
feat/faster_blurhash
branch
from
2f66b2e to
e53b6be
Compare
nielsvanvelzen
approved these changes
Jul 16, 2024
|
Awesome, thanks for the contribution! I've tweaked the styling a bit more (adding new lines, moving the CHARS const to the top and using when statements instead of if statements). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replace the Kotlin Multiplatform BlurHash library with a new local implementation of the decoder which is at least 2 times faster while using less memory (no cache is needed).
For details about the optimizations and some benchmarks, see woltapp/blurhash#254.