Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in player backdrop #3751

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

nielsvanvelzen
Copy link
Member

When the "next up" screen hides, the previous screen will activate for a brief moment (limitation of how our current navigation code works). If you opened the video player via the FullDetailsFragment this will cause the item to reload, and once that loading finishes it will set a backdrop. However, during this asynchronous operation the app will already have started the video player again. This ends up showing the backdrop in the video player... oops

Changes

  • Validate lifecycle in FullDetailsFragment.setBaseItem

Issues
Fixes #3728

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Jul 14, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jul 14, 2024
@nielsvanvelzen nielsvanvelzen merged commit 9e41a8b into jellyfin:master Jul 14, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the fix-player-bg branch July 14, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backdrop surrounds played film and Next Up box in jellyfin-androidtv-v0.17.0-beta.2-debug
2 participants