-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a blur to backdrop images #3674
Conversation
I don't mind adding a blur to the background, that most likely improves the design. But adding an option for it is entirely unnecessary. |
Yes I agree, another menu item is rather cumbersome. I was just unsure if you wanted this feature by default or by user pref so I added it just in case. I will update my branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the invalid formatting that needs to be fixed I found one issue, the server splash screen when authenticating should not be blurred.
app/src/main/java/org/jellyfin/androidtv/ui/background/AppBackground.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/background/AppBackground.kt
Outdated
Show resolved
Hide resolved
…ground.kt Co-authored-by: Niels van Velzen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Hello, where does the 'enable' option appear within the Android TV interface? - cannot be seen on the 'Customization' section; it only appears the "Show backdrops" option. Currently running Server 10.9.9 and AndroidTV Jellyfin 0.17.3 |
Background blur is always enabled on supported devices (Android 12 and newer). |
Hello. Is it possible to disable this features. I have a headache while reading text and scrolling. Blur effect is across whole screen and it does not like nice. |
Please open an issue for that. If there's enough demand we may add an option for it. |
Changes
Add a checkbox in the Theme customization view to blur the backdrop images. Add blurBackdropEnable to UserPreferences. Add _blur to BackgroundService. Add conditional modifier in AppBackground Image() to blur using androidx.compose.ui.draw.blur.
Issues
fix #3642