Refactor FullDetailsFragment to use SDK #3591
Conversation
nielsvanvelzen
added
sdk-migration
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
|
|
||
| play(episodes.items, 0, false) | ||
| } catch (err: ApiClientException) { |
Check warning
Code scanning / detekt
The caught exception is swallowed. The original exception could be lost. Warning
| @@ -1466,12 +1351,13 @@ | |||
| } | |||
|
|
|||
| RecordPopup mRecordPopup; | |||
| public void showRecordingOptions(String id, final org.jellyfin.sdk.model.api.BaseItemDto program, final boolean recordSeries) { | |||
|
|
|||
| public void showRecordingOptions(String id, final BaseItemDto program, final boolean recordSeries) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -1466,12 +1351,13 @@ | |||
| } | |||
|
|
|||
| RecordPopup mRecordPopup; | |||
| public void showRecordingOptions(String id, final org.jellyfin.sdk.model.api.BaseItemDto program, final boolean recordSeries) { | |||
|
|
|||
| public void showRecordingOptions(String id, final BaseItemDto program, final boolean recordSeries) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
|
|
||
| private DisplayMetrics mMetrics; | ||
|
|
||
| protected org.jellyfin.sdk.model.api.BaseItemDto mProgramInfo; | ||
| protected BaseItemDto mProgramInfo; |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| protected SeriesTimerInfoDto mSeriesTimerInfo; | ||
| protected UUID mItemId; | ||
| protected UUID mChannelId; | ||
| protected BaseRowItem mCurrentItem; | ||
| private Instant mLastUpdated; | ||
| private UUID mPrevItemId; | ||
| public UUID mPrevItemId; |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -257,11 +257,11 @@ | |||
| staticHeight = true; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, BaseItemPerson[] people, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
| public ItemRowAdapter(List<BaseItemPerson> people, Context context, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -257,11 +257,11 @@ | |||
| staticHeight = true; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, BaseItemPerson[] people, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
| public ItemRowAdapter(List<BaseItemPerson> people, Context context, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -257,11 +257,11 @@ | |||
| staticHeight = true; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, BaseItemPerson[] people, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
| public ItemRowAdapter(List<BaseItemPerson> people, Context context, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -257,11 +257,11 @@ | |||
| staticHeight = true; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, BaseItemPerson[] people, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
| public ItemRowAdapter(List<BaseItemPerson> people, Context context, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
Changes
This PR updates the FullDetailsFragment to use the SDK for all non-livetv code. There's still 15 direct API calls left for Live TV. Will tackle those at some point in the future.
Some behavior changes had to be made because of some Live TV hacks (SeriesTimers is not a valid BaseItem type). Also some (small) cleaning done. Overall this file is a PITA to deal with as it tries to literally support all the item types we have.
Issues