Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preferences for screensaver age rating #3513

Merged

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Apr 16, 2024

This change adds age rating preferences for the screensaver. It depends on jellyfin/jellyfin#11367.

This is not the exact implementation that I wanted, ideally the maximum age rating preference would show the parental ratings from the server. There are two problems with it though:

  • There is a breaking API change in 10.9 and the SDK we're currently using breaks because of it
    • Not a huge problem as 0.17 is most likely going to require 10.9, still annoying now that we're using the older SDK version
  • The responses are not localized, some names are hardcoded (unrated/approved/banned)
    • And even if they used the server language, the client might want a different language. We'd need to add Accept-Language support to both the API and SDK for this to work properly. Which might be something to look at for 10.10, but definitely not 10.9

Adding the mapping via the server is something we can always add later though.

Changes

  • Add preference for screensaver "require age rating"

    • Defaults to on (changed behavior since 0.16)
    • When turned on, only items with an age rating set will show
    • When turned off, all items will show
  • Add preference for screensaver "maximum age rating"

    • Defaults to 13 (same behavior as 0.16)
    • Can also be set to a few different values, notable are 0 and -1.
    • -1 means "no maximum", parameter will be omitted in requests

Screenshots

9460000320

9080000321

Issues

Fixes #3320

@nielsvanvelzen nielsvanvelzen added enhancement New feature or request release-highlight Pull request might be suitable for mentioning in the release blog post labels Apr 16, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Apr 16, 2024
@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review April 17, 2024 17:21
@nielsvanvelzen nielsvanvelzen force-pushed the screensaver-agerating-prefs2 branch from fb6daf2 to 7ed7490 Compare April 17, 2024 18:00
@nielsvanvelzen nielsvanvelzen force-pushed the screensaver-agerating-prefs2 branch from 7ed7490 to 0fbb862 Compare April 17, 2024 18:13
@nielsvanvelzen nielsvanvelzen merged commit a9928fb into jellyfin:master Apr 18, 2024
6 checks passed
@nielsvanvelzen nielsvanvelzen deleted the screensaver-agerating-prefs2 branch April 18, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-highlight Pull request might be suitable for mentioning in the release blog post
Projects
Development

Successfully merging this pull request may close these issues.

Option to exclude libraries from screensaver
2 participants