Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to pick a random item to the smart screen #3487

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Apr 6, 2024

Works for movies, tv series and music (random album)

Changes

  • Add button to pick a random item to the smart screen
  • Use BaseItemKind enum in some more places

image

Issues

Works for movies, tv series and music (random album)
@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Apr 6, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Apr 6, 2024
@@ -82,7 +84,7 @@
protected static final int SERIES = 11;
protected static final int ALBUM_ARTISTS = 12;
protected BaseItemDto mFolder;
protected String itemTypeString;
protected BaseItemKind itemType;

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

object BrowsingUtils {
@JvmStatic
fun getRandomItem(api: ApiClient, lifecycle: LifecycleOwner, library: BaseItemDto, type: BaseItemKind, callback: (item: BaseItemDto?) -> Unit) {

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style. Warning

Line detected, which is longer than the defined maximum line length in the code style.
@nielsvanvelzen nielsvanvelzen merged commit a13babe into jellyfin:master Apr 6, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the smartscreen-random branch April 7, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants