Improve info row colors #3448
Improve info row colors #3448
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| val Green = Color(0xFF30843D) | ||
| val Red = Color(0xFFB20000) | ||
| val Transparent = Color.Transparent to Color.White | ||
| val Default = Color(0x80FFFFFF) to Color.Black |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| val Red = Color(0xFFB20000) | ||
| val Transparent = Color.Transparent to Color.White | ||
| val Default = Color(0x80FFFFFF) to Color.Black | ||
| val Green = Color(0x8034D97C) to Color.Black |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| val Transparent = Color.Transparent to Color.White | ||
| val Default = Color(0x80FFFFFF) to Color.Black | ||
| val Green = Color(0x8034D97C) to Color.Black | ||
| val Red = Color(0x80F2364D) to Color.Black |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
Changes
Update the colors used in the new InfoRow (#3379) to some better ones. I've shamefully stolen them from the Figma lab project. The background colors all have 50% transparency, creating some sort of "glassy" effect.
The biggest improvement is in the used red/green colors because I really hated those. They're missing in the screenshots though.
Before
After
Issues