Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show specials for seasons #3292

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

nielsvanvelzen
Copy link
Member

Turns out it was possible, just needed to touch some spaghet.

Changes

  • Support SpecialsQuery in BrowseRowDef/EnhancedBrowseFragment
  • Show specials row in GenericFolderFragment when type is season

Issues

Fixes #3009

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Jan 6, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jan 6, 2024
@@ -195,6 +197,12 @@
this.changeTriggers = changeTriggers;
}

public BrowseRowDef(String header, SpecialsQuery query) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@@ -195,6 +197,12 @@
this.changeTriggers = changeTriggers;
}

public BrowseRowDef(String header, SpecialsQuery query) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@@ -254,6 +262,8 @@

public GetResumeItemsRequest getResumeQuery() { return resumeQuery; }

public SpecialsQuery getSpecialsQuery() { return specialsQuery; }

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@nielsvanvelzen nielsvanvelzen merged commit 706a05e into jellyfin:master Jan 7, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the nvv-season-specials branch January 7, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show extras that are part of Seasons folder
2 participants