Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to sort by runtime #3084

Merged
merged 5 commits into from
Feb 3, 2024
Merged

Add ability to sort by runtime #3084

merged 5 commits into from
Feb 3, 2024

Conversation

bathompson
Copy link
Contributor

Changes
I added the ability to sort media by ascending runtime.

@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Oct 7, 2023
nielsvanvelzen
nielsvanvelzen requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this only works on movie libraries. This option should be hidden for for other library types.

@bathompson
Copy link
Contributor Author

It looks like this only works on movie libraries. This option should be hidden for for other library types.

Ok this should be taken care of now.

@nielsvanvelzen nielsvanvelzen removed this from the v0.17.0 milestone Dec 15, 2023
@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Dec 18, 2023
@nielsvanvelzen
Copy link
Member

Hey @bathompson there are still some review comments left before we can merge this.

@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Feb 3, 2024
@nielsvanvelzen nielsvanvelzen enabled auto-merge (rebase) February 3, 2024 15:02
@nielsvanvelzen nielsvanvelzen merged commit 1fdaa87 into jellyfin:master Feb 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horizon1250 horizon1250 horizon1250 approved these changes

@boc-the-git boc-the-git boc-the-git approved these changes

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bathompson @nielsvanvelzen @boc-the-git @horizon1250