Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Travis test for Ruby 1.9 #87

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Remove Travis test for Ruby 1.9 #87

merged 1 commit into from
Jan 18, 2017

Conversation

paulrobertlloyd
Copy link
Contributor

@paulrobertlloyd paulrobertlloyd commented Jan 16, 2017

Hello @jekyll/archives. In the interests of keeping development of this important (IMHO!) plugin progressing, and in the spirit of being proactive (and following on from the discussion in #58), I’ve updated the Travis tests to remove tests for Ruby 1.9 /Jekyll 2.0.

Somewhat related, I removed the version forking in the code, and bumped the minimum supported Jekyll version to 3.0. Controversial? Maybe, but Jekyll 3.0 is 15 months old now. Ducks

@paulrobertlloyd
Copy link
Contributor Author

Phew! Do let me know if I’ve made the right changes to the Travis config. @parkr @alfredxing

@pathawks
Copy link
Member

Please don't modify History.markdown. @jekyllbot will take care of that when PRs are merged 👍

It seems this would be best if it were just 408aeb6 without duplicating everything in #58

@paulrobertlloyd
Copy link
Contributor Author

@pathawks Ah. I only updated History.markdown because it made no reference to the 2.1.1 release, so appeared outdated. Not sure how the bots go about their work around here… 😉

Honestly, I’m happy whatever gets committed, just eager to see (and help!) things move forwards.

@paulrobertlloyd paulrobertlloyd changed the title Update project dependancies and tests to support incremental rebuilds Move to support for Jekyll >= 3.0 and update related Travis tests Jan 17, 2017
@paulrobertlloyd paulrobertlloyd changed the title Move to support for Jekyll >= 3.0 and update related Travis tests Move to support for Jekyll >= 3.0 Jan 17, 2017
@paulrobertlloyd
Copy link
Contributor Author

paulrobertlloyd commented Jan 17, 2017

@pathawks Okay, I’ve reduced the scope of this PR to that of supporting Jekyll 3.0 and above only.

I’m guessing such a change necessitates moving to a major version bump? As such, I wonder if @alfredxing wants to include a few other updates and fixes in such a version? Not sure. FYI, I’m hoping to figure out how we can make this plugin accept any array of documents, so not just site.posts but site.documents or site.[collection].docs.

@alfredxing
Copy link
Member

Looks good to me! Thanks @paulrobertlloyd 😄

It would be a breaking change, so unfortunately we would have to bump the major version 😦

I don't think this would be too much of an issue though; most people should be using Jekyll 3.0 by now!

@parkr
Copy link
Member

parkr commented Jan 18, 2017

We can always remove support for 1.9.3 without removing support for Jekyll 2.0. It seems pretty easy to hold onto?

Copy link
Member

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulrobertlloyd Would you mind squashing changes, so we don't alter the Git history of History.markdown? I can help with that, if you need.

@paulrobertlloyd
Copy link
Contributor Author

@pathawks Happy to squash. I’ve never done this before, so do please let me know what steps I need to take.

@alfredxing @parkr Oh, maybe I could limit this PR to the Travis config, and to remove testing on Ruby 1.9.3? I wrongly assumed there was a stronger link between Ruby 1.9.3 and Jekyll 2.0, but I guess older versions of Jekyll 2.0 will work with newer flavours of Ruby.

@DirtyF
Copy link
Member

DirtyF commented Jan 18, 2017

@paulrobertlloyd You can squash commits easily with GitKraken GUI.

https://support.gitkraken.com/working-with-files/commits

Squash commits

👍 for a simple PR that removes testing on Ruby 1.9.x

@pathawks
Copy link
Member

Or from command line:

git reset 67e56d79241225faa0fed1867034226bb0ee54ee
git commit -a

@paulrobertlloyd paulrobertlloyd changed the title Move to support for Jekyll >= 3.0 Remove Travis test for Ruby 1.9 Jan 18, 2017
@paulrobertlloyd
Copy link
Contributor Author

Thanks for the tip about GitKraken @DirtyF, I’ll have to take a look at that in more detail as it looks very helpful.

Meanwhile, with a bit of ‘close my eyes and press Enter‘ in the terminal, I believe I’ve now squashed the commit log for this PR. Is this correct @pathawks?

@pathawks
Copy link
Member

@paulrobertlloyd ❤️👍

@parkr
Copy link
Member

parkr commented Jan 18, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 7849387 into jekyll:master Jan 18, 2017
jekyllbot added a commit that referenced this pull request Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants