Make Archive subclass of Page #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Archive a subclass of Jekyll::Page, and render it using the regular Page pipleline. This should fix long-standing issue #28.
|
LGTM once tests pass. :)
|
|
Just found an issue around this with CloudCannon. Any chance we can get this merged in to add the archives to site.pages? |
|
LGTM! @jekyllbot: merge +minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Archive a subclass of Jekyll::Page, and render it using the regular Page pipeline. This should also fix long-standing issue #28.
As with incremental regen, this would still be affected by the post-listing content bug (which I'm still thinking about how to fix!). So if users are going to use
{{ post.content}}on archive pages, they'll probably still have to disable incremental for now.